Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow rewrite of Mage_Core_Model_File_Validator_Image #1337

Merged
merged 1 commit into from
Jan 10, 2021
Merged

Allow rewrite of Mage_Core_Model_File_Validator_Image #1337

merged 1 commit into from
Jan 10, 2021

Conversation

luigifab
Copy link
Contributor

Description

This PR allow to rewrite Mage_Core_Model_File_Validator_Image with config.xml.
I need these change for one of my module :).

<config>
 <global>
  <models>
   <core>
    <rewrite>
     <file_validator_image>Example_Example_Model_Example</file_validator_image>
    </rewrite>
   </core>
  </models>
 </global>
</config>

OpenMage 20.0.4 / PHP 7.4.11

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Catalog Relates to Mage_Catalog labels Dec 10, 2020
@sreichel sreichel added this to the Release 19.4.10 / 20.0.6 milestone Jan 10, 2021
@sreichel sreichel merged commit d9e2d0d into OpenMage:1.9.4.x Jan 10, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  1 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌
2 runs  2 ✔️ 0 💤 0 ❌

Results for commit d9e2d0d.

@luigifab luigifab deleted the allow-rewrite-validator-image branch January 10, 2021 08:50
@luigifab luigifab restored the allow-rewrite-validator-image branch April 6, 2021 15:44
@luigifab luigifab deleted the allow-rewrite-validator-image branch April 6, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreichel sreichel sreichel approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Catalog Relates to Mage_Catalog new feature
Projects
None yet
Milestone
Release 19.4.10 / 20.0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@luigifab @colinmollenhour @sreichel