Adding useful feedback to Gd2.php exceptions

[loekvangool]

Description

Manual testing scenarios

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)

[colinmollenhour]

Are these exceptions ever visible to users or are they just logged?

[loekvangool]

I got this thrown at the admin user by an extension that creates a product feed for a SaaS search solution. The exception caused complete failure of the feed generation job. A message like does not contain enough information to be called "actionable" imo, and thus has to be expanded and we should probably consider not creating exceptions for this at all (all that happened was that there were a few stray BMP and TIFF images in the media dir). Also, the Mage frontend did not display these images for the accompanying products. There actually was no message logged in any of these cases, maybe we should add Mage::logException() calls as well. If this happens during a cron job it will just fail silently.

Lastly, we might consider merging https://github.com/magento-hackathon/Perfect_Watermarks for imagemagick support (I see you have forked that repo already).

[addison74]

Lastly, we might consider merging https://github.com/magento-hackathon/Perfect_Watermarks for imagemagick support (I see you have forked that repo already).

This project was not updated for more than 6 years. It is based on imaginemagick which had security issues. Just read an issue posted in 2016 here magento-hackathon/Perfect_Watermarks#24.

[loekvangool]

Lastly, we might consider merging https://github.com/magento-hackathon/Perfect_Watermarks for imagemagick support (I see you have forked that repo already).

This project was not updated for more than 6 years. It is based on imaginemagick which had security issues. Just read an issue posted in 2016 here magento-hackathon/Perfect_Watermarks#24.

The code could be updated.

The security issue is easily mitigated, for instance for CentOS see https://access.redhat.com/security/vulnerabilities/ImageTragick.

[luigifab]

Someone have a test script to test this PR?

[addison74]

Even if I don't consider the wording "was" appropriate the change is useful to identify where the error comes from.

[loekvangool]

Even if I don't consider the wording "was" appropriate the change is useful to identify where the error comes from.

Yeah agreed, made a new PR