Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating phpstorm meta files with magerun 2.1.0 #1365

Merged
merged 4 commits into from
Mar 11, 2021
Merged

Updating phpstorm meta files with magerun 2.1.0 #1365

merged 4 commits into from
Mar 11, 2021

Conversation

boesbo
Copy link
Contributor

@boesbo boesbo commented Dec 28, 2020 •
edited by sreichel
Loading

Updating phpstorm meta files with magerun 2.1.0. This solves the compatibility problem with the PHPStorm Stubs library used for example in the vscode PHP-Intelephense extension.

Related Pull Requests

netz98/n98-magerun#1141

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

colinmollenhour
colinmollenhour reviewed Dec 29, 2020
View reviewed changes
Copy link
Member

@colinmollenhour colinmollenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this adds some classes that don't exist in the core.

Flyingmana
Flyingmana previously approved these changes Jan 7, 2021
View reviewed changes
kiatng
kiatng previously approved these changes Jan 8, 2021
View reviewed changes
@boesbo boesbo dismissed stale reviews from kiatng and Flyingmana via 98c1150 January 14, 2021 23:18
sreichel
sreichel requested changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@sreichel sreichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove that two classes.

@sreichel sreichel merged commit cf5cda9 into OpenMage:1.9.4.x Mar 11, 2021
@sreichel sreichel added this to the Release 19.4.12 / 20.0.8 milestone Mar 11, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit cf5cda9. ± Comparison against base commit 79e36ff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreichel sreichel sreichel approved these changes

@kiatng kiatng kiatng approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@Flyingmana Flyingmana Awaiting requested review from Flyingmana

Assignees
No one assigned
Labels
environment
Projects
None yet
Milestone
Release 19.4.12 / 20.0.8
Development

Successfully merging this pull request may close these issues.
5 participants
@boesbo @colinmollenhour @Flyingmana @kiatng @sreichel