Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed adminhtml boxes.css fieldset-wide for note. #1370

Merged
merged 1 commit into from
Jan 14, 2021

Conversation

kiatng
Copy link
Contributor

@kiatng kiatng commented Jan 4, 2021

Description (*)

Wide fieldset can be set like this:

// extends Mage_Adminhtml_Block_Widget_Form

$fieldset = $form->addFieldset('set_sns', [
    'legend' => $helper->__('Certificate S/Ns'),
    'class' => 'fieldset-wide'
]);

However the width of the note attribute is .form-list td.value p.note { width:268px; }. The following screenshot shows before and after the fix.

image

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@sreichel sreichel added the Template : admin Relates to admin template label Jan 14, 2021
@sreichel sreichel merged commit 5ddb7a3 into OpenMage:1.9.4.x Jan 14, 2021
@sreichel sreichel added this to the Release 19.4.10 / 20.0.6 milestone Jan 14, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5ddb7a3. ± Comparison against base commit e1c10c5.

@sreichel sreichel mentioned this pull request Jan 14, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Template : admin Relates to admin template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants