Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Declare two variables #1378

Merged
merged 1 commit into from
Jan 10, 2021
Merged

Declare two variables #1378

merged 1 commit into from
Jan 10, 2021

Conversation

luigifab
Copy link
Contributor

@luigifab luigifab commented Jan 8, 2021 •
edited
Loading

Description

This PR declare two variables as array.
OpenMage 20.0.5 / PHP 7.4.11 - 8.0.0

Manual testing scenarios

Create a new empty database, set it in your local.xml, clear cache, then go to index.php to regenerate the database.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@sreichel sreichel assigned sreichel and unassigned sreichel Jan 9, 2021
@sreichel sreichel added the Component: Usa Relates to Mage_Usa label Jan 10, 2021
@sreichel sreichel added this to the Release 19.4.10 / 20.0.6 milestone Jan 10, 2021
@sreichel sreichel merged commit 95c4228 into OpenMage:1.9.4.x Jan 10, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 95c4228. ± Comparison against base commit 6270dc4.

@luigifab luigifab deleted the variable-declaration branch January 10, 2021 08:50
@luigifab luigifab restored the variable-declaration branch April 6, 2021 15:44
@luigifab luigifab deleted the variable-declaration branch April 6, 2021 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreichel sreichel sreichel approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
Cleanup Component: Usa Relates to Mage_Usa
Projects
None yet
Milestone
Release 19.4.10 / 20.0.6
Development

Successfully merging this pull request may close these issues.
3 participants
@luigifab @colinmollenhour @sreichel