Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icons in admin (icon-head) #1384

Merged
merged 1 commit into from
May 12, 2021
Merged

Add icons in admin (icon-head) #1384

merged 1 commit into from
May 12, 2021

Conversation

luigifab
Copy link
Contributor

@luigifab luigifab commented Jan 9, 2021 •
edited
Loading

Description

This PR add some icons for titles.

screen

OpenMage 20.0.5 / PHP 8.0.0

Manual testing scenarios

Try Sales, Catalog, Customers, Promotions, Newsletter, CMS, and Reports menu items in admin.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Newsletter Relates to Mage_Newsletter Component: PayPal Relates to Mage_Paypal Component: Reports Relates to Mage_Reports Template : admin Relates to admin template labels Jan 9, 2021
kiatng
kiatng previously approved these changes Jan 10, 2021
View reviewed changes
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkrieger85 kkrieger85 merged commit 434e403 into OpenMage:1.9.4.x May 12, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  +4  4 ✔️ +2  2 💤 +2  0 ❌ ±0 

Results for commit 434e403. ± Comparison against base commit 5ddb7a3.

@luigifab luigifab deleted the adminhtml-icons branch May 12, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreichel sreichel sreichel approved these changes

@kkrieger85 kkrieger85 kkrieger85 approved these changes

@kiatng kiatng kiatng left review comments

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Newsletter Relates to Mage_Newsletter Component: PayPal Relates to Mage_Paypal Component: Reports Relates to Mage_Reports Template : admin Relates to admin template
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luigifab @kiatng @kkrieger85 @sreichel