Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix class name and filename for case sensitive filesystems #1390

Merged
merged 2 commits into from
Jan 14, 2021
Merged

Fix class name and filename for case sensitive filesystems #1390

merged 2 commits into from
Jan 14, 2021

Conversation

kdckrs
Copy link
Contributor

@kdckrs kdckrs commented Jan 11, 2021

Description (*)

Adds support for "SameSite" cookie property #1246 is throwing some errors on case-sensitive file systems. This PR fixes this.

Related Pull Requests

Fixed Issues (if relevant)

Fixes compatibility with case sensitive file systems see #1246

Manual testing scenarios (*)

In the backend, on General > Web, Magento's autoloader attempts to load Mage_Adminhtml_Model_System_Config_Source_Cookie_Samesite , while the class file is named "SameSite.php" (with an upper "Site" in it). The file is not auto-loaded on case sensitive filesystems, and causes wild errors.
(Taken from @ansgarbecker in the linked PR)

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Jan 11, 2021
@kdckrs
Copy link
Contributor Author

kdckrs commented Jan 11, 2021

@Flyingmana something up with the Github Actions? Unit tests step failed on the "publish results" step:

github.GithubException.GithubException: 403 {"message": "Resource not accessible by integration", "documentation_url": "https://docs.github.com/rest/reference/checks#create-a-check-run"}

@sreichel sreichel added the bug label Jan 13, 2021
@ansgarbecker
Copy link

@kdckrs Could you retry merging? I'm not sure why that was neccessary but I guess with 59983f9 this should pass through now.

@kdckrs
Copy link
Contributor Author

kdckrs commented Jan 14, 2021

@kdckrs Could you retry merging? I'm not sure why that was neccessary but I guess with 59983f9 this should pass through now.

All good now ;)

@tmotyl tmotyl mentioned this pull request Jan 14, 2021
@tmotyl tmotyl merged commit 134149c into OpenMage:1.9.4.x Jan 14, 2021
@sreichel sreichel added this to the Release 19.4.10 / 20.0.6 milestone Jan 14, 2021
@sreichel sreichel linked an issue Jan 14, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Classname wrong
4 participants