Fix PHP8 Deprecated: Required parameter $A follows optional parameter #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Adminhtml
|
Why this commit was closed? It should be merged in OpenMage. |
colinmollenhour
approved these changes
Apr 22, 2021
Flyingmana
approved these changes
May 23, 2021
| @@ -131,11 +131,11 @@ public function removeButton($id) | |||
| * Update specified button property | |||
| * | |||
| * @param string $id | |||
| * @param string|null $key | |||
| * @param string $key | |||
There was a problem hiding this comment.
it still accepts null as a param for this
| $queryString = $queryString."</CardinalMPI>"; | ||
| return "cmpi_msg=".urlencode($queryString); | ||
| } | ||
| function getRequestXml() |
| @@ -162,11 +162,11 @@ protected function _updateButton($id, $key=null, $data) | |||
| * Public wrapper for protected _updateButton method | |||
| * | |||
| * @param string $id | |||
| * @param string|null $key | |||
| * @param string $key | |||
There was a problem hiding this comment.
it still accepts null as a param here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Should fix all "Required parameter $A follows optional parameter $B warnings.
Manual testing scenarios (*)
Contribution checklist (*)