Fix regression in configuration scope code. Refs #1417

[colinmollenhour]

Description (*)

Fixes regression as reported by @addison74 in #1417

Fixed Issues (if relevant)

Config scope switching is fixed.

[addison74]

This change will solve all issues reported by those who could not save the modifications made in system configuration section. Personally I was affected by not seeing Template Hints working in Frontend then I started a deep investigation. Fortunately I found the issue. I tested this solution and working.

@colinmollenhour: I appreciate for your fast reaction.

[kiatng]

Tested and worked.

[sreichel]

Did not test, but (bool)(int)$field-> is also used for _isValidField($field).

Edit: tested

[addison74]

There is a similar solution already from the past as @sreichel mentioned before in file /app/code/core/Mage/Adminhtml/Model/Config/Data.php. In this case it was done correctly (lines 449 - 474):

/**
 * Check field visibility by scope
 *
 * @param Mage_Core_Model_Config_Element $field
 * @return bool
 */
protected function _isValidField($field)
{
    if (!$field) {
        return false;
    }

    switch ($this->getScope()) {
        case self::SCOPE_DEFAULT:
            return (bool)(int)$field->show_in_default;
            break;
        case self::SCOPE_WEBSITES:
            return (bool)(int)$field->show_in_website;
            break;
        case self::SCOPE_STORES:
            return (bool)(int)$field->show_in_store;
            break;
    }

    return true;
}

[sreichel]

@Flyingmana can you pls make a hotfix release? This should not wait for days/weeks.

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit eaf4354. ± Comparison against base commit bbd05be.

[Flyingmana]

@sreichel I cant, my calendar is already full for the next 2 weeks