Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ascending alphabetical sort for Attribute Set Name #1424

Merged
merged 4 commits into from
Feb 25, 2021
Merged

Ascending alphabetical sort for Attribute Set Name #1424

merged 4 commits into from
Feb 25, 2021

Conversation

addison74
Copy link
Contributor

@addison74 addison74 commented Jan 23, 2021

A first modification allows the ascending alphabetical order of the list containing the attribute sets on the [Attrib. Set Name] column in Magento Backend -> Catalog -> Manage Products page.

It is useful for those who have a long list of sets of attributes. Magento sorts them by default as they were created, so it's very difficult to identify a particular set in a long list, especially since there is no possibility to filter the column.

Here is the result in production this store has almost 120 attributes sets:

screenshot_new

Another modification is useful when creating a New Product. The attribute sets list is sorted too.

2

The third modification sorts Attribute Sets lists when creating a new attribute set:

3

And finally this modification sorts Unassigned Attributes list in Edit Attribute Page:

screenshot2

This modification allows the ascending alphabetical order of the list containing the attribute sets on the [Attrib. Set Name] in Magento Backend -> Catalog -> Manage Products page.
@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Jan 23, 2021
ADDISON added 3 commits January 23, 2021 22:31
This modification allows the ascending alphabetical order of the list containing the attribute sets when creating a New Product.
Copy link
Contributor

@sreichel sreichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful! No time to test, but LGTM.

@sreichel sreichel merged commit 15ea4aa into OpenMage:1.9.4.x Feb 25, 2021
@sreichel sreichel added this to the Release 19.4.12 / 20.0.8 milestone Feb 25, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 15ea4aa. ± Comparison against base commit bbd05be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants