Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed menu cursor #1441

Merged
merged 1 commit into from
Feb 13, 2021
Merged

Fixed menu cursor #1441

merged 1 commit into from
Feb 13, 2021

Conversation

midlan
Copy link
Contributor

@midlan midlan commented Feb 2, 2021

Description (*)

Fixes the menu cursor for items that is link and have childs simultaneously, e.g.:
image

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Template : admin Relates to admin template labels Feb 2, 2021
@kiatng
Copy link
Contributor

kiatng commented Feb 3, 2021

I cannot replicate the cursor fix in this PR. However, I can fix it by changing line 90 from { cursor:default; } to { cursor:pointer }

#nav li.parent a,
#nav li.parent li.parent a,
#nav li.parent li.parent li.parent a { cursor:default; }

Screenshots of the 2 cursors:
image

Is that what this PR is about? Or am I missing something?

@midlan
Copy link
Contributor Author

midlan commented Feb 3, 2021

@kiatng it fixes the situation the parent is link itself (they have href="someurl") - it should have pointer cursor. Otherwise there is parents that are not links (they have href="#") so they shouldn't have pointer cursor.

@Flyingmana Flyingmana merged commit f84c396 into OpenMage:1.9.4.x Feb 13, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f84c396. ± Comparison against base commit 4b17235.

@sreichel sreichel added this to the Release 19.4.11 / 20.0.7 milestone Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml Template : admin Relates to admin template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants