Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log Exception the right way in Session, no need for custom message formatting anymore #1443

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Log Exception the right way in Session, no need for custom message formatting anymore #1443

merged 1 commit into from
Apr 29, 2021

Conversation

woutersamaey
Copy link
Contributor

Just some minor cleanup.

@github-actions github-actions bot added the Component: Core Relates to Mage_Core label Feb 3, 2021
@woutersamaey woutersamaey mentioned this pull request Feb 3, 2021
Merged
@woutersamaey
Copy link
Contributor Author

woutersamaey commented Feb 17, 2021 •
edited
Loading

Can we get this approved @Flyingmana @sreichel @colinmollenhour @kiatng ?

Sekiphp
Sekiphp approved these changes Mar 28, 2021
View reviewed changes
Copy link
Contributor

@Sekiphp Sekiphp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Flyingmana Flyingmana changed the title Log Exception the right way, no need for custom message formatting anymore Log Exception the right way in Session, no need for custom message formatting anymore Apr 29, 2021
@Flyingmana Flyingmana merged commit f7089e7 into OpenMage:1.9.4.x Apr 29, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f7089e7. ± Comparison against base commit 4b17235.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sekiphp Sekiphp Sekiphp approved these changes

@kiatng kiatng kiatng approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
Component: Core Relates to Mage_Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@woutersamaey @colinmollenhour @kiatng @Sekiphp @Flyingmana