make Developer Mode controllable by environment variable for all execution paths #1445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using environment variable. Relocate switch to Mage.php to allow for CLI.
|
I've had this code for so long I didn't realize it was a customization. The only difference is I put it in bootstrap.php. |
joshua-bn
previously approved these changes
Feb 3, 2021
sreichel
previously approved these changes
Mar 2, 2021
Oops.. that's my habitual style, I find it a lot easier to read. :D |
colinmollenhour
commented
Mar 4, 2021
colinmollenhour
dismissed stale reviews from sreichel and kkrieger85
via
b5f6492
|
Sorry for being pandetic :) |
kkrieger85
approved these changes
Mar 5, 2021
sreichel
approved these changes
Mar 11, 2021
Flyingmana
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows developer mode to easily be controlled by an environment variable, for example set in the docker container and moves the logic to Mage.php so it can work from any script (index.php, api.php, get.php, cron.php, custom scripts). It is enabled by default in the bundled docker-based environment.