Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _isDownloader flag #1448

Merged
merged 1 commit into from
May 12, 2021
Merged

Remove _isDownloader flag #1448

merged 1 commit into from
May 12, 2021

Conversation

luigifab
Copy link
Contributor

@luigifab luigifab commented Feb 4, 2021

This PR remove an useless flag about the downloader.

@github-actions github-actions bot added the Mage.php Relates to app/Mage.php label Feb 4, 2021
@Flyingmana
Copy link
Contributor

can we be sure, nobody is actually using this?
I would say we should mark it with a @ deprecated annotation only for now.

@luigifab
Copy link
Contributor Author

luigifab commented Feb 7, 2021

I kept the method and added deprecated.

@luigifab luigifab closed this Apr 6, 2021
@luigifab luigifab deleted the no-downloader branch April 6, 2021 15:46
@luigifab luigifab restored the no-downloader branch April 15, 2021 10:02
@luigifab luigifab reopened this Apr 15, 2021
@kkrieger85 kkrieger85 merged commit c57eb3a into OpenMage:1.9.4.x May 12, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  +4  4 ✔️ +2  2 💤 +2  0 ❌ ±0 

Results for commit c57eb3a. ± Comparison against base commit 2310733.

@luigifab luigifab deleted the no-downloader branch May 12, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mage.php Relates to app/Mage.php
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants