Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Massaction items - removed unused switch #1455

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

Sekiphp
Copy link
Contributor

@Sekiphp Sekiphp commented Feb 8, 2021

Description (*)

Code behavior should be still the same. Removed unnecessary switch statement.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: Adminhtml Relates to Mage_Adminhtml label Feb 8, 2021
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual creation of form based on the param $config is in

class Mage_Adminhtml_Block_Widget_Grid_Massaction_Item_Additional_Default extends Mage_Adminhtml_Block_Widget_Form implements Mage_Adminhtml_Block_Widget_Grid_Massaction_Item_Additional_Interface
{
public function createFromConfiguration(array $configuration)
{
$form = new Varien_Data_Form();
foreach ($configuration as $itemId=>$item) {
$item['class'] = isset($item['class']) ? $item['class'] . ' absolute-advice' : 'absolute-advice';
$form->addField($itemId, $item['type'], $item);
}
$this->setForm($form);
return $this;
}
}

@Flyingmana Flyingmana merged commit ce3171d into OpenMage:1.9.4.x Apr 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2021

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit ce3171d. ± Comparison against base commit 2310733.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants