Mage_Core_Model_Abstract: Fix rollback when Throwable is thrown in save/delete method

[Sekiphp]

Description (*)

When you throw some child of Error class (or Error class) in _beforeSave or in _afterSave methods - Magento do not rollback started transaction and it is provide error:

PHP implementation:
Error implements Throwable
Exception implements Throwable

Manual testing scenarios (*)

Consider this code:

class Namespace_Module_Model_Foo extends Mage_Core_Model_Abstract {
    protected function _beforeSave()
    {
        parent::_beforeSave();

        throw new Error('error from some specifiec reason');
    }
}

Mage::getModel('namespace_module/foo')->save();

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)

[LukasCesal]

Funny when you are upgrading to LTS and get another bunch of errors :-) thank you Luboš

[kiatng]

See also PR #1442

[Sekiphp]

@kiatng Yeah, I seen it. But we should merge this pull request first - less code, less potentional breaking. This is tested on our OpenMage instance and solving real issue, which is described here.

[kiatng]

@Sekiphp First, as you said, you have already fixed this in your project. Others facing similar issue can likewise fix them in their respective projects, no issue there. Second, for maintaining OpenMage code base, we need to fix Throwable for all instances, this helps to maintain code quality in terms of consistency, eg, use of $t or $e. We can better progress OpenMage this way. I hope you agree.

[colinmollenhour]

Good change! Thanks for the PR!

nitpick: Please fix the vardoc and delete() as well while you're at it.

[Sekiphp]

@colinmollenhour Added throws annotation and fixed delete() method

• I changed Throwable $t to Throwable $e, because I read the specifications, and in official PHP examples is $e instead of $t:

• https://wiki.php.net/rfc/throwable-interface
• Throwable Interface php/php-src#1284

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  +4  4 ✔️ +2  0 💤 ±0  2 ❌ +2 

Results for commit 3c9fb54. ± Comparison against base commit 0e2f81d.