Old inactive quotes are now actually purged from the database

[FredericMartinez]

Description (*)

Since the beggining of Magento, only quotes converted to orders can be deleted by sales_clean_quotes cron because quote collection filter on is_active=0 ​

---

Show quotes group by year

select YEAR(updated_at), count('*')
from sales_flat_quote
GROUP BY YEAR(updated_at)

YEAR(updated_at)	count('*')
2018	1014080
2019	404537
2020	159526
2021	46765

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)

[rvelhote]

I was thinking about this issue last week.

Our sales_flat_quote table is at ~2.15 million records and there is a situation where the trigger_recollect flag might be modified for all quotes due to a catalog rule or price modification (maybe more reasons?).

I believe that this was the cause for the dreaded SQLSTATE[HY000]: General error: 1205 Lock wait timeout exceeded; try restarting transaction, query was: XYZ we experienced last week. The table took 3 to 5 minutes fo fully update which stopped customers from adding products to the cart during that timeframe - it's possible/likely, however, that it was executed multiple times in succession rather than just once.

I'm still in the process of investigating this issue and mitigation and reducing the table would have a very positive effect.

[joshua-bn]

Yikes. If checkout/cart/delete_quote_after is empty for whatever reason, it will cause all active quotes to break. Please, whatever you do, put a default on that.

I just checked the value I have. It's 0. That would be very, very bad if that ever ran on production for me.

[fballiano]

what are we doing on this @FredericMartinez?

[FredericMartinez]

@fballiano I removed the filter, old active non-active quotes are now purged.
Already in production since years, I have never saw a breaking change

[luigifab]

If checkout/cart/delete_quote_after is empty for whatever reason, it will cause all active quotes to break.

A check is needed no? For example, if empty, keep is_active filter?

[kiatng]

If checkout/cart/delete_quote_after is empty for whatever reason, it will cause all active quotes to break.

A check is needed no? For example, if empty, keep is_active filter?

We cannot merge this until this is addressed: all active quotes will be deleted if checkout/cart/delete_quote_after is empty.

A suggestion:

    public function cleanExpiredQuotes($schedule)
    {
        Mage::dispatchEvent('clear_expired_quotes_before', array('sales_observer' => $this));
        $lifetimes = Mage::getConfig()->getStoresConfigByPath('checkout/cart/delete_quote_after');
        foreach ($lifetimes as $storeId => $day) {
            $day = (int) $day;
            $lifetime = 86400 * $day;
            /** @var Mage_Sales_Model_Mysql4_Quote_Collection $quotes */
            $quotes = Mage::getModel('sales/quote')->getCollection();

            $quotes->addFieldToFilter('store_id', $storeId);
            $quotes->addFieldToFilter('updated_at', array('to'=>date("Y-m-d", time()-$lifetime)));
            if ($day === 0) {
                $quotes->addFieldToFilter('is_active', 0);
            }
            // ...

Also add a note in the backend, something like:

Please suggest better English.

[luigifab]

With the comment, I also suggest to add in system.xml: <validate>validate-not-negative-number</validate>

[fballiano]

we've to take a look at what @kiatng is saying

[luigifab]

I updated and merged with Github web editor.

The base branch was changed.

[fballiano]

I've rebased it and I think it's ready to be merged

[kyrena]

Ping @kiatng and @FredericMartinez for latest PR update 😸.