Removed unnecessary replacing of variable from parent

[Sekiphp]

Description (*)

Mage_Directory_Model_Resource_Country_Collection extending Varien_Data_Collection where is $_items already defined:

    /**
     * Collection items
     *
     * @var array
     */
    protected $_items = array();

And there was diferrent initial value.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)

[midlan]

We will loose phpdoc (typehint) by this?

[midlan]

👍 resolved in ea13c48

[colinmollenhour]

On the vardocs, I like to add methods like this:

/**
 * @method Mage_Directory_Model_Country getFirstItem()
 * @method Mage_Directory_Model_Country getLastItem()
 * @method null|Mage_Directory_Model_Country getItemById($idValue)
 * @method Mage_Directory_Model_Country[] getItems()
 * @method Mage_Directory_Model_Country[] getIterator()

The last one in particular is helpful when iterating a collection so that the loop value has correct type hinting automatically, at least in PhpStorm.

[sreichel]

The last one in particular is helpful when iterating a collection so that the loop value has correct type hinting automatically, at least in PhpStorm.

Which phpStorm version do you use? I thought this would already work?

Wait ... no time to check, but I solved in another way. I added something like @method SomeClass[] getCollection(), but not for all classes yet. See #784. I'd prefer my way, because all methods are covered. (if i'm right here)

[colinmollenhour]

PhpStorm is smart enough to use the return type of getIterator() inside a loop to determine the iterator item type because Varien_Data_Collection implements IteratorAggregate. So if getIterator() hints Mage_Directory_Model_Country[] then this will work with no additional hints ($country will be detected as an instance of Mage_Directory_Model_Country):

foreach (Mage::getResourceModel('directory/country_collection') as $country) {
    $country->getIso2Code(); // returns string
}

Also this:

Mage::getResourceModel('directory/country_collection')->getFirstItem()->getIso2Code(); // returns string

My example with @method annotations is the only way I know to get this to work.

[sreichel]

@colinmollenhour you're right. getIterator() is something i missed for all doc block update :/

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3e24f15. ± Comparison against base commit 48fe4d8.