Remove Deprecated _afterSaveCommit from Mage_Core_Model_Abstract #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiatng
approved these changes
Mar 17, 2021
|
The change looks good but I think we need to record in a changelog type file somewhere about all potentially breaking changes.. Do you have a preference on how to handle this @Flyingmana? |
Flyingmana
approved these changes
Mar 27, 2021
Flyingmana
changed the title
|
I usually take the PR Title as base for the Changelog. Have modified the Title so it is highlighted. We still should create a documentation page going further into changes between Major Versions which contain BC breaking changes (like removed deprecated functions). But as long as its in the changelog, its currently not a priority. |
colinmollenhour
approved these changes
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Removed method which was marked as deprecated more than 10 years ago.
Contribution checklist (*)