Fixed incorrect datetime in block.

[kiatng]

Description (*)

This PR fixes 2 issues:

1. Incorrect datetime in backend customer page, see issue Strange date time issues in customer view #466.
2. Enable the ability to formatDate() in the block without converting to store timezone. A use case is when a datetime is stored in the DB in local timezone (or a date such as birthdate, which is independent of timezone), the method formatDate() would convert the datetime and couldn't be used for rendering. This PR fixes that. Now, the same method can be used.

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes Strange date time issues in customer view #466

Manual testing scenarios (*)

After:

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)

[addison74]

I do not agree changing the code by replacing if/else sequences with ternary operator ?. The code is just fine as it is the only necessary change should be fixing the issue.

Although I understand that you want a compression of the code but it is not beneficial for the reader. It is much easier for me personally to see if/else sequences then ?. If we agree to such changes then we should do so throughout Magento, otherwise we lose the rules initially set.

[fballiano]

I also don't like the 1 line functions, but anyways we need this merged asap

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  +4  6 ✔️ +4  0 💤 ±0  0 ❌ ±0 

Results for commit e69b326. ± Comparison against base commit 42988a6.

[sreichel]

Is this a BC breaking change?

[kiatng]

Is this a BC breaking change?

I think so, due to addition of new param $useTimezone in public function formatDate($date = null, $format = Mage_Core_Model_Locale::FORMAT_TYPE_SHORT, $showTime = false, $useTimezone = true). Existing method without $useTimezone that overrides it will run into PHP exceptions.

[sreichel]

IMHO ... this change to formatDate() method should be reverted.

I'd add a new method that covers $useTimezone = true parameter and can be used to fix the issue.