Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PHP8 error in App.php: method_exists() now throws an exception if the first argument is not string|object #1540

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Fix PHP8 error in App.php: method_exists() now throws an exception if the first argument is not string|object #1540

merged 1 commit into from
Apr 12, 2021

Conversation

himanshu007-creator
Copy link
Contributor

@himanshu007-creator himanshu007-creator commented Apr 10, 2021 •
edited
Loading

Description (*)

Related Pull Requests

#1539

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: Core Relates to Mage_Core label Apr 10, 2021
@kiatng kiatng added the PHP 8 Related to PHP8 label Apr 10, 2021
kiatng
kiatng approved these changes Apr 10, 2021
View reviewed changes
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the first arg of method_exists() accepts either string or object; but in this case, we do not expect it to be a string.

@kiatng kiatng removed the PHP 8 Related to PHP8 label Apr 10, 2021
@Flyingmana Flyingmana merged commit 3e75b9e into OpenMage:1.9.4.x Apr 12, 2021
@Flyingmana Flyingmana changed the title Update App.php Fix PHP8 error in App.php: method_exists() now throws an exception if the first argument is not string|object Apr 12, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3e75b9e. ± Comparison against base commit 28ecfb5.

@Flyingmana Flyingmana added the PHP 8 Related to PHP8 label Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng approved these changes

@Flyingmana Flyingmana Flyingmana approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
Component: Core Relates to Mage_Core PHP 8 Related to PHP8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@himanshu007-creator @colinmollenhour @Flyingmana @kiatng