Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert update to Prototype serialize method that breaks OpenMage functionality. Fixes #1549 #1552

Merged
merged 1 commit into from
Apr 17, 2021
Merged

Revert update to Prototype serialize method that breaks OpenMage functionality. Fixes #1549 #1552

merged 1 commit into from
Apr 17, 2021

Conversation

colinmollenhour
Copy link
Member

OpenMage depends on the old behavior of Prototype form serialization so this reverts that part back while keeping all of the other Prototype updates.

See #1549

@github-actions github-actions bot added the JavaScript Relates to js/* label Apr 16, 2021
@colinmollenhour colinmollenhour mentioned this pull request Apr 16, 2021
Closed
@addison74
Copy link
Contributor

So far so good. It works as expected.

@Flyingmana Flyingmana merged commit 56cf1f1 into OpenMage:1.9.4.x Apr 17, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 56cf1f1. ± Comparison against base commit d44a8dd.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flyingmana Flyingmana Flyingmana approved these changes

Assignees
No one assigned
Labels
JavaScript Relates to js/*
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@colinmollenhour @addison74 @Flyingmana