Mark invoice as last when dummy items included

[mattdavenport]

This commit fixes invoice generation when an order contains configurable or bundled items.

This is a backported fix from Magento 2, as this bug exists in M1 as well. When a configurable or dummy item is included on an order, and custom tax collectors are used the tax total is off due to $invoice->isLast() being false and the code choosing the tax total of only items+shipping (in Mage_Sales_Model_Order_Invoice_Total_Tax). This has been testing with multiple-invoiced orders as well and works as expected.

Thanks!

[colinmollenhour]

Very nice!

[Flyingmana]

there is a comparable part in \Mage_Sales_Model_Order_Creditmemo::isLast

magento-lts/app/code/core/Mage/Sales/Model/Order/Creditmemo.php

Lines 1023 to 1031 in f37c26d

	public function isLast()
	{
	foreach ($this->getAllItems() as $item) {
	if (!$item->isLast()) {
	return false;
	}
	}
	return true;
	}

Can we have dummy Items there, too?

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  +4  4 ✔️ +2  0 💤 ±0  2 ❌ +2 

Results for commit 3cf56b5. ± Comparison against base commit 6b663bb.