-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not startEnvironmentEmulation for current store #1578
Do not startEnvironmentEmulation for current store #1578
Conversation
I wouldn't have changed the $exception variable name but other than that wow... this is a great PR. |
@luigifab did you check the phpstan notes? |
Yes for all, if |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isset()
could be merged
Co-authored-by: sv3n <github-sr@hotmail.com>
Co-authored-by: sv3n <github-sr@hotmail.com>
Co-authored-by: sv3n <github-sr@hotmail.com>
Co-authored-by: sv3n <github-sr@hotmail.com>
Co-authored-by: sv3n <github-sr@hotmail.com>
Co-authored-by: sv3n <github-sr@hotmail.com>
Co-authored-by: sv3n <github-sr@hotmail.com>
Co-authored-by: sv3n <github-sr@hotmail.com>
niceeee I didn't know that syntax! |
Description
This PR do not run
startEnvironmentEmulation
when the targeted store is the current store.I don't know if this is the best way, for now our emails seem to keep working.
When a customer place an order, the new order email is sent.
To do that,
startEnvironmentEmulation
is triggered.Three screenshots from BlackFire, before:



After:
OpenMage 20.0.10 / PHP 7.4.6
Manual testing scenarios
Contribution checklist