Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset array on product reset #1582

Merged
merged 1 commit into from
May 4, 2021
Merged

Reset array on product reset #1582

merged 1 commit into from
May 4, 2021

Conversation

luigifab
Copy link
Contributor

Description

This PR fix #724.

I found also _defaultValues and _lockedAttributes.
Not sure if it's useful to clear them or not.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: Catalog Relates to Mage_Catalog label Apr 30, 2021
@fballiano
Copy link
Contributor

great find @luigifab, do you think it is safe to reset also _defaultValues and _lockedAttributes?

@luigifab
Copy link
Contributor Author

luigifab commented May 4, 2021

@fballiano this is a reset, so I think it's safe.

@Flyingmana Flyingmana merged commit 8b0c0b9 into OpenMage:1.9.4.x May 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2021

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  ±0  4 ✔️ ±0  2 💤 +2  0 ❌  - 2 

Results for commit 8b0c0b9. ± Comparison against base commit cc3eff3.

@luigifab luigifab deleted the reset-store-values-flags branch May 4, 2021 14:59
@luigifab luigifab restored the reset-store-values-flags branch June 6, 2021 11:14
@luigifab luigifab deleted the reset-store-values-flags branch June 6, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sekiphp Sekiphp Sekiphp approved these changes

@Flyingmana Flyingmana Flyingmana approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
Component: Catalog Relates to Mage_Catalog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resetting the catalog product model must empty the array _storeValuesFlags
5 participants
@luigifab @fballiano @colinmollenhour @Flyingmana @Sekiphp