fixed twitter share link, issue 1595 #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Catalog
Flyingmana
previously approved these changes
May 4, 2021
|
yeah, we can do the "proper" sending of the url via separate parameter as a separate task, if it is offering an improvement |
|
I didn't think about doing that but makes sense, I separated the URL parameter already and updated the PR. |
colinmollenhour
approved these changes
May 5, 2021
fballiano
changed the title
Flyingmana
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #1595
It's done in a slightly different way (to keep the product name in the shared tweet) compared to the one suggested by the original reporter.