-
-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix README.md contributors badge #1627
Conversation
I don't know much about this badge but I think the "101" part of the url is basically meant to be dynamically replaced by the All Contributors bot so this PR would break that. Granted, it is already broken! 😄 #1614 |
Oh I understand, by fixing this I maybe broke the bot in charge of changing this dynamically. |
DON'T MERGE MY PULL REQUEST. I read more about all-contributors-bot config, I think installation have to be checked and workflow to add contributor was not respected. |
@mehdichaouch yes there is somewhere a related ticket. We did not "install" the all contributors bot, because it needs write access to the repository, which could be used in a possible supply-chain-attack. Means, it needs to be manually run and used to create PullRequests |
@Flyingmana thank you for your answer. So what about the badge, do you have a solution do fix it? |
Is this something you could document somewhere very briefly like an internal wiki? |
what are we doing with this? it's really ugly to have a broken README |
Iam ok with merging it for now to fix the obvious error and take care of the automatism separately |
@all-contributors add @mehdichaouch doc |
I've put up a pull request to add @mehdichaouch! 🎉 |
Fix README.md contributors badge, causing the display of badge url code.