Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not load captcha.js when disabled #1628

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Do not load captcha.js when disabled #1628

merged 1 commit into from
Jul 13, 2021

Conversation

luigifab
Copy link
Contributor

@luigifab luigifab commented May 20, 2021 •
edited
Loading

Description

When captcha is not enabled on front (login page...), mage/captcha.js is loaded.
This PR check the configuration to load or not the file.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added Component: Captcha Relates to Mage_Captcha Template : base Relates to base template XML Layout labels May 20, 2021
kiatng
kiatng approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and worked!

@Flyingmana Flyingmana merged commit 0fb1845 into OpenMage:1.9.4.x Jul 13, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  ±0  4 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 0fb1845. ± Comparison against base commit 9b04ad2.

@luigifab luigifab deleted the captcha-front branch July 13, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng approved these changes

@fballiano fballiano fballiano approved these changes

@colinmollenhour colinmollenhour colinmollenhour approved these changes

Assignees
No one assigned
Labels
Component: Captcha Relates to Mage_Captcha Template : base Relates to base template XML Layout
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@luigifab @colinmollenhour @fballiano @kiatng @Flyingmana