Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fatal error - getRegionCollection() - issue #713 #1644

Merged
merged 2 commits into from
May 28, 2021
Merged

Fix fatal error - getRegionCollection() - issue #713 #1644

merged 2 commits into from
May 28, 2021

Conversation

Sekiphp
Copy link
Contributor

@Sekiphp Sekiphp commented May 26, 2021 •
edited
Loading

Description (*)

Fix fatal error when getRegionCollection() is called

Related Pull Requests

#718

Fixed Issues (if relevant)

  1. [Bug] Mage_Directory_Helper_Data::getRegionCollection() #713
  2. Mage_Directory_Helper_Data::getRegionCollection - dependency inside method #1639

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: Directory Relates to Mage_Directory label May 26, 2021
@Sekiphp Sekiphp requested review from sreichel and kiatng May 26, 2021 19:12
@Sekiphp @kiatng
Update app/code/core/Mage/Directory/Helper/Data.php
f912fd8 
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
@Flyingmana Flyingmana mentioned this pull request May 28, 2021
Merged
@Flyingmana Flyingmana merged commit 308ad52 into OpenMage:1.9.4.x May 28, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  ±0  4 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 308ad52. ± Comparison against base commit 76e8fe3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng approved these changes

@Flyingmana Flyingmana Flyingmana approved these changes

@sreichel sreichel Awaiting requested review from sreichel

Assignees
No one assigned
Labels
Component: Directory Relates to Mage_Directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sekiphp @Flyingmana @kiatng