Simple improve of Not valid template file debugging #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple improve of Not valid template file debugging
tmotyl
reviewed
Feb 8, 2017
|
You can adjust in transit and accept.
…On Wed, Feb 8, 2017 at 11:50 AM, Tymoteusz Motylewski < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In app/code/core/Mage/Core/Block/Template.php
<#165 (review)>
:
> @@ -240,7 +240,8 @@ public function fetchView($fileName)
if ($includeFilePath != '' && (strpos($includeFilePath, realpath($this->_viewDir)) === 0 || $this->_getAllowSymlinks())) {
include $includeFilePath;
} else {
- Mage::log('Not valid template file:'.$fileName, Zend_Log::CRIT, null, true);
+ $thisClass = get_class($this);
+ Mage::log('Not valid template file:'.$fileName." class:{$thisClass}", Zend_Log::CRIT, null, true);
just a nitpick, I would prefer not to mix style of concatenating strings -
single qoutes/double quotes. and sugges sth like:
Mage::log('Not valid template file:' . $fileName . ' class: ' .
$thisClass, Zend_Log::CRIT, null, true);
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#165 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAn0a17j9s2ZVK5jFxIcMbh7arU00oZWks5raZ3rgaJpZM4L6lmK>
.
|
tmotyl
approved these changes
Feb 8, 2017
colinmollenhour
approved these changes
Feb 8, 2017
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Dec 6, 2017
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Dec 6, 2017
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Feb 28, 2018
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Mar 20, 2018
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Jul 17, 2018
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Sep 19, 2018
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Feb 14, 2019
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Apr 1, 2019
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 22, 2019
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Oct 25, 2019
sreichel
added
Cleanup: Code style
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple improve of Not valid template file debugging