Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves the PHP 7 error: Declaration of Mage_Tag_Model_Api_V2::items... #1674

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

boesbo
Copy link
Contributor

@boesbo boesbo commented Jun 4, 2021

Description (*)

Resolves the PHP 7 error:
Declaration of Mage_Tag_Model_Api_V2::items($productId, $store) should be compatible with Mage_Tag_Model_Api::items($productId, $store = NULL)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

… ) should be compatible with Mage_Tag_Model_Api::items(, = NULL)
@github-actions github-actions bot added the Component: Tag Relates to Mage_Tag label Jun 4, 2021
@boesbo boesbo changed the title Resolves the PHP error: Declaration of Mage_Tag_Model_Api_V2::items(,… Resolves the PHP 7 error: Declaration of Mage_Tag_Model_Api_V2::items... Jun 4, 2021
@Flyingmana Flyingmana added PHP 7.x Related to PHP 7.x PHP 8 Related to PHP8 labels Jun 4, 2021
@Flyingmana Flyingmana merged commit 94563c7 into OpenMage:1.9.4.x Jun 4, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2021

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  ±0  4 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 94563c7. ± Comparison against base commit 4d2ce08.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Tag Relates to Mage_Tag PHP 7.x Related to PHP 7.x PHP 8 Related to PHP8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants