Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed phpdoc of Mage_Core_Model_Resource_Db_Collection_Abstract::addExpressionFieldToSelect #1689

Merged
merged 1 commit into from
Jul 6, 2021
Merged

Fixed phpdoc of Mage_Core_Model_Resource_Db_Collection_Abstract::addExpressionFieldToSelect #1689

merged 1 commit into from
Jul 6, 2021

Conversation

midlan
Copy link
Contributor

@midlan midlan commented Jun 17, 2021

Fixed phpdoc of Mage_Core_Model_Resource_Db_Collection_Abstract::addExpressionFieldToSelect

Description (*)

Fixed wrong phpdoc parameter datatype and usage example.

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. go to your IDE, call collection method addExpressionFieldToSelect with third parameter string. It should not be highlighted as datatype mismatch.
  2. test examples mentioned in Example: section

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@midlan
Fixed phpdoc
237277e 
Fixed phpdoc of Mage_Core_Model_Resource_Db_Collection_Abstract::addExpressionFieldToSelect
@midlan midlan added the Cleanup: DOC blocks Related to DOC block updates and fixes. label Jun 17, 2021
@github-actions github-actions bot added the Component: Core Relates to Mage_Core label Jun 17, 2021
@Flyingmana Flyingmana merged commit 8c25b15 into OpenMage:1.9.4.x Jul 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2021

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  ±0  4 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 8c25b15. ± Comparison against base commit 94563c7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@Flyingmana Flyingmana Flyingmana approved these changes

Assignees
No one assigned
Labels
Cleanup: DOC blocks Related to DOC block updates and fixes. Component: Core Relates to Mage_Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@midlan @Flyingmana @fballiano