Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not load product when it is already loaded #1698

Merged
merged 1 commit into from
Jun 25, 2021
Merged

Do not load product when it is already loaded #1698

merged 1 commit into from
Jun 25, 2021

Conversation

luigifab
Copy link
Contributor

@luigifab luigifab commented Jun 24, 2021

Description

When review/form block is added to the product page, without this PR, the product is loaded a second time.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added the Component: Review Relates to Mage_Review label Jun 24, 2021
@Flyingmana Flyingmana merged commit 1f0779e into OpenMage:1.9.4.x Jun 25, 2021
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
6 runs  ±0  4 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 1f0779e. ± Comparison against base commit 94563c7.

@luigifab luigifab deleted the no-reload-product branch June 25, 2021 20:16
@luigifab
Copy link
Contributor Author

luigifab commented Sep 3, 2021

I noticed that ($product->getId() == $this->getRequest()->getParam('id')) doesn't work with Turpentine+Varnish, because esi URL doesn't contain the id parameter. Simple solution: remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Review Relates to Mage_Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants