Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix paypal IPN postback response parsing #194

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

bob2021
Copy link
Contributor

@bob2021 bob2021 commented Feb 28, 2017

I'm not sure where this fix first came from, I've seen it posted on a few different blogs and forums.

The IPN class always expects a status code to be on the second line of the response, but curl sometimes adds extra HTTP headers, so it is better to look for the status code on the last line of the response instead.

@tbaden tbaden added the review needed Problem should be verified label Jun 1, 2019
tbaden
tbaden previously approved these changes Jun 2, 2019
Copy link

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seansan
Copy link
Contributor

seansan commented Oct 11, 2019

Whats the status of this? Has it been tested ... can it be merged?

@sreichel sreichel added the Component: PayPal Relates to Mage_Paypal label Jun 1, 2020
@dbachmann
Copy link
Contributor

Hey there,

a customer of mine got this mail from paypal too and I've checked this issue. After changed the code and tested again everything works fine now.

@Flyingmana
Copy link
Contributor

that means we have 2 approves and can merge it now.

@Flyingmana Flyingmana changed the base branch from 1.9.3.x to 1.9.4.x March 1, 2021 12:05
@Flyingmana Flyingmana dismissed tbaden’s stale review March 1, 2021 12:05

The base branch was changed.

@Flyingmana Flyingmana merged commit 0e2f81d into OpenMage:1.9.4.x Mar 1, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2021

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
2 runs  ±0  2 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 0e2f81d. ± Comparison against base commit 7e8ccf5.

@sreichel sreichel added bug and removed review needed Problem should be verified labels Mar 3, 2021
@sreichel sreichel added this to the Release 19.4.12 / 20.0.8 milestone Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Component: PayPal Relates to Mage_Paypal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants