-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent Zend_Date from checking locale for know date codes #2050
Prevent Zend_Date from checking locale for know date codes #2050
Conversation
Add U, X and c, as we know the codes are not real locales.
With this many, I would use in_array() or isset() so it's more readable. But, looks good. |
can we know a little bit more about this? |
@fballiano sure, this change is a performance optimization that we run on prod since more than a year. |
Thanks @tmotyl! |
@fballiano I have found the issue when investigating (profiling with blackfire) why some magento reports are taking ages to load / timeout.
Its a best practice, as both sides are strings, it doesn't make sense to have "!=" |
Add U, X and c, as we know the codes are not real locales.