Fix xml validation problems #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: Api
addison74
previously approved these changes
Jun 21, 2022
kiatng
previously requested changes
Jun 26, 2022
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
|
@kiatng I think I commited all your suggestions, thanks! |
fballiano
requested review from
addison74,
colinmollenhour,
kkrieger85,
Sekiphp,
Flyingmana,
sreichel and
tmotyl
Flyingmana
approved these changes
Jul 10, 2022
|
If a value cannot be assigned to {{var wsdl.name}} then this manual change is absolutely necessary. |
tmewes
approved these changes
Jul 10, 2022
elidrissidev
approved these changes
Jul 12, 2022
elidrissidev
pushed a commit
to elidrissidev/magento-lts
that referenced
this pull request
Jul 22, 2022
Flyingmana
added
the
backwards compatibility
|
note: changing the schema name to OpenMage was breaking Integrations with external services (reported on a different place, for example here #2539 (comment)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're trying to introduce XML validation as a github workflow, the commonly used technique is running xmllit with something like:
find . -type f -iname '*.xml' | xargs -I '{}' xmllint --noout '{}'problem is, xmllint is broken because our XMLs have a "name" variable in some places.
Since that variable was always replaced with "Magento" I figured to:
Fixed Issues (if relevant)
This PR is part of the fix for #1918
Manual testing scenarios (*)
You've the command line in the task description.
Also check that APIs work.