Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some ReturnTypeWillChange annotations to Varien_object #2301

Merged
merged 1 commit into from
Jul 12, 2022
Merged

add some ReturnTypeWillChange annotations to Varien_object #2301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/Varien/Object.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,6 +842,7 @@ public function debug($data=null, &$objects=array())
* @param string $offset
* @param mixed $value
*/
#[ReturnTypeWillChange]
public function offsetSet($offset, $value)
{
$this->_data[$offset] = $value;
Expand All @@ -854,6 +855,7 @@ public function offsetSet($offset, $value)
* @param string $offset
* @return boolean
*/
#[ReturnTypeWillChange]
public function offsetExists($offset)
{
return isset($this->_data[$offset]);
Expand All @@ -865,6 +867,7 @@ public function offsetExists($offset)
* @link http://www.php.net/manual/en/arrayaccess.offsetunset.php
* @param string $offset
*/
#[ReturnTypeWillChange]
public function offsetUnset($offset)
{
unset($this->_data[$offset]);
Expand All @@ -877,6 +880,7 @@ public function offsetUnset($offset)
* @param string $offset
* @return mixed
*/
#[ReturnTypeWillChange]
public function offsetGet($offset)
{
return isset($this->_data[$offset]) ? $this->_data[$offset] : null;
Expand Down