Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a notice #2318

Merged
merged 5 commits into from
Jul 21, 2022
Merged

Fixes a notice #2318

merged 5 commits into from
Jul 21, 2022

Conversation

azambon
Copy link
Contributor

@azambon azambon commented Jul 14, 2022

Description (*)

After this commit de06e67 the code in the checkout has not been updated to look for the session validation data in the new location. As such a PHP notice is generated.

This PR avoids the notice by updating the code to fetch the session validation data in the correct place.

Related Pull Requests

Fixed Issues (if relevant)

Fixes issue #2285

Manual testing scenarios (*)

  • Set PHP to display notices
  • Setup Mageto to allow checking out as a guest
  • Go to the checkout and choose to checkout and register a new account
  • Submit the order
  • You should see a notice about an array key which is not set, which is the key of the missing session validation data
  • After applying this PR, the same scenario should create an order and register the new customer without any notice.

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

After this commit OpenMage@de06e67 the code in the checkout has not been updated to look for the session validation data in the new location. As such a PHP notice is generated.

This PR avoids the notice by updating the code to fetch the session validation data in the correct place.
@github-actions github-actions bot added the Component: Checkout Relates to Mage_Checkout label Jul 14, 2022
app/code/core/Mage/Checkout/Model/Type/Onepage.php Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Component: Core Relates to Mage_Core label Jul 15, 2022
@elidrissidev
Copy link
Member

Is this supposed to be a fix for #2285? If so please link it with this PR.

@azambon
Copy link
Contributor Author

azambon commented Jul 15, 2022

@elidrissidev Yes, it is! I missed that issue, sorry.

@elidrissidev elidrissidev linked an issue Jul 15, 2022 that may be closed by this pull request
Copy link
Member

@elidrissidev elidrissidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and all good.

@fballiano fballiano dismissed Flyingmana’s stale review July 21, 2022 12:07

@azambon made the suggested changes

Copy link
Contributor

@fballiano fballiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fballiano fballiano merged commit 646a480 into OpenMage:1.9.4.x Jul 21, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 646a480. ± Comparison against base commit 042d4e5.

elidrissidev pushed a commit to elidrissidev/magento-lts that referenced this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Checkout Relates to Mage_Checkout Component: Core Relates to Mage_Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setPasswordCreatedAt() leads to PHP Warning
5 participants