Correct usage for adding items to ArrayObject

[sreichel]

Description (*)

Correct usage for adding items to ArrayObject ...

Manual testing scenarios (*)

https://phpstan.org/r/4eaed64e-ec9f-44ae-bc8e-83a020ff3163

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[fballiano]

Since the arrayObject is casted to array before returning... why don't we just convert everything to an array?

[sreichel]

This could break observers that rely on $errors being ArrayObject ...

magento-lts/app/code/core/Mage/Admin/Model/User.php

Lines 616 to 619 in f1b41d3

	Mage::dispatchEvent('admin_user_validate', array(
	'user' => $this,
	'errors' => $errors,
	));

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit ff13954. ± Comparison against base commit 8d2a11b.