An Exception is thrown and logged if file is not found while merging

[fballiano]

If css/js merging is enabled but one of the files doesn't exist on the file system, the merging was re-done at every request, as explained in #874

This should be avoided and an exception should be logged.

On line 837 of app/code/core/Mage/Core/Helper/Data.php all the exceptions are logged and I've added that message (with the comment above) to be consistent with the rest of the code.

[sreichel]

What i have to do, to trigger this error?

I've eanbled css/js-merging, deleted a few files (that should be merged?!?), cleared cache ...

[fballiano]

I don't know, I've just put that issue into code 😅

[elidrissidev]

@sreichel I tested it, if a file is not found the error is caught and logged to var/log/exception.log.

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 10704a1. ± Comparison against base commit 32d1591.

[addison74]

Lately there are more and more tests that fail for PHP Stan - .github/phpstan.neon. For this PR the error is the following

Error: Cannot call method addTitleToResult() on Mage_Core_Model_Resource_Db_Collection_Abstract|false.
 ------ -------------------------------------------------------- 
  Line   Catalog/Model/Resource/Product/Option/Collection.php    
 ------ -------------------------------------------------------- 
  152    Cannot call method addTitleToResult() on                
         Mage_Core_Model_Resource_Db_Collection_Abstract|false.  
 ------ --------------------------------------------------------

Is it a problem that we merged it without fixing this error?

[elidrissidev]

Is it a problem that we merged it without fixing this error?

Already fixed in another pending PR.

[fballiano]

I think it started with #2562, #2572 should fixes it but I'm also trying to understand why it generated, which i still don't know

[fballiano]

found it now :-)