Added two indexes on sales_flat_order and sales_flat_order_item tables #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobihille
previously approved these changes
Aug 19, 2022
addison74
previously approved these changes
Aug 19, 2022
tobihille
previously approved these changes
Aug 23, 2022
addison74
previously approved these changes
Aug 23, 2022
|
Tested on 1million sales_flat_order_items rows on my local machine and took only a few seconds (10ish, also considering that cache was cold) so I guess it will not create troubles even to big stores in production. |
addison74
previously approved these changes
Aug 25, 2022
addison74
previously approved these changes
Sep 18, 2022
sreichel
reviewed
Sep 18, 2022
app/code/core/Mage/Sales/sql/sales_setup/upgrade-1.6.0.10-1.6.0.11.php
Outdated
Show resolved
Hide resolved
sreichel
reviewed
Sep 18, 2022
app/code/core/Mage/Sales/sql/sales_setup/upgrade-1.6.0.10-1.6.0.11.php
Outdated
Show resolved
Hide resolved
sreichel
reviewed
Sep 18, 2022
sreichel
reviewed
Sep 18, 2022
app/code/core/Mage/Sales/sql/sales_setup/upgrade-1.6.0.10-1.6.0.11.php
Outdated
Show resolved
Hide resolved
sreichel
reviewed
Sep 18, 2022
app/code/core/Mage/Sales/sql/sales_setup/upgrade-1.6.0.10-1.6.0.11.php
Outdated
Show resolved
Hide resolved
sreichel
requested changes
Sep 21, 2022
There was a problem hiding this comment.
Please check my suggestion ... when i reset version in core_resource table an run update again ...
Error in file: "/var/www/html/app/code/core/Mage/Sales/sql/sales_setup/upgrade-1.6.0.10-1.6.0.11.php" - SQLSTATE[42000]: Syntax error or access violation: 1061 Duplicate key name 'IDX_SALES_FLAT_ORDER_CUSTOMER_EMAIL'
…0.11.php Co-authored-by: sv3n <github-sr@hotmail.com>
|
it should be ok now |
sreichel
approved these changes
Sep 22, 2022
addison74
approved these changes
Sep 22, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solution was already discussed and agreed in issue #384 I just created the PR into the Mage_Sales module since in 2022 I don't see the need for a new dedicated module for this specific task (as discussed in the previously linked issue).