Bugfix to avoid newline character \n in customFormSubmit URL

[eneiasramos]

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

1. ...
2. ...

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All automated tests passed successfully (all builds are green)
• Add yourself to contributors list

[sreichel]

Thanks. Can you please add some/most relevant information? Reviews are easier when you know the problem from reading and see how its fixed :) (imho)

[eneiasramos]

@sreichel I was inspecting an issue with the onclick event and a 3rd party plugin, then I found this:

a javascript call with \n between the parameters.

[sreichel]

I agree with this change to put this in one line, but i'd use .... without $_cartUrl

onclick="customFormSubmit('<?php echo $this->getAddToCartUrlCustom($_product, [], false) ?>', '<?php echo $_params ?>', 'post')">

[eneiasramos]

@sreichel I understand your point of view but I followed the same pattern as the lines below:

magento-lts/app/design/frontend/rwd/default/template/catalog/product/list.phtml

Line 104 in 4db847a

<?php $_wishlistUrl = $this->helper('wishlist')->getAddUrlWithCustomParams($_product, [], false); ?>

magento-lts/app/design/frontend/rwd/default/template/catalog/product/list.phtml

Line 110 in 4db847a

onclick="customFormSubmit('<?php echo $_wishlistUrl ?>', '<?php echo $_params ?>', 'post')">

magento-lts/app/design/frontend/rwd/default/template/catalog/product/list.phtml

Line 115 in 4db847a

<?php if ($_compareUrl = $this->getAddToCompareUrlCustom($_product, false)) : ?>

magento-lts/app/design/frontend/rwd/default/template/catalog/product/list.phtml

Line 120 in 4db847a

onclick="customFormSubmit('<?php echo $_compareUrl ?>', '<?php echo $_params ?>', 'post')">

[sreichel]

I understand your point of view but I followed the same pattern as the lines below:

Ah okay. Next time, please put such info into PR description ... :)

[github-actions]

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 5d9036e. ± Comparison against base commit 4db847a.

[eneiasramos]

I understand your point of view but I followed the same pattern as the lines below:

Ah okay. Next time, please put such info into PR description ... :)

@sreichel perfect my dear! I will do this :)

Thank you! o/