Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpstan: fixes for Varien_Data_Collection #2524

Merged
merged 4 commits into from
Sep 1, 2022
Merged

Conversation

sreichel
Copy link
Contributor

Description (*)

phpdocs/phpstan fix.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions

This comment has been minimized.

@sreichel sreichel marked this pull request as draft August 30, 2022 23:02
@sreichel sreichel changed the title Fixed phpstan for Mage_Reports_Model_Resource_Report_Collection::initReport() phpstan: fixes for Varien_Data_Collection Aug 30, 2022
@sreichel sreichel marked this pull request as ready for review August 31, 2022 01:28
@github-actions github-actions bot added Component: Backup Relates to Mage_Backup Component: Catalog Relates to Mage_Catalog Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* labels Aug 31, 2022
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@sreichel sreichel marked this pull request as draft August 31, 2022 01:35
@sreichel sreichel marked this pull request as ready for review August 31, 2022 02:27
@github-actions github-actions bot added Component: AdminNotification Relates to Mage_AdminNotification Component: Admin Relates to Mage_Admin Component: CatalogSearch Relates to Mage_CatalogSearch Component: Core Relates to Mage_Core Component: Eav Relates to Mage_Eav Component: Rating Relates to Mage_Rating Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales labels Aug 31, 2022
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@fballiano fballiano force-pushed the phpstan-init-report branch from b184d1c to 35b5002 Compare August 31, 2022 08:43
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@kiatng
Copy link
Contributor

kiatng commented Sep 1, 2022

Do you have plan to fix this:

image

If the filtering is enabled in the grid, then the collection should have Varien_Data_Collection_Db as parent:

     * @param Varien_Data_Collection|Varien_Data_Collection_Db $collection
     */
    public function getCollection($collection)
    // and: public function setCollection($collection)

@sreichel sreichel mentioned this pull request Sep 1, 2022
4 tasks
@sreichel
Copy link
Contributor Author

sreichel commented Sep 1, 2022

Do you have plan to fix this:

Yes. The "problem" is, that is has no impact on phpstan ... so i dont see it during my tests. Made a new PR. :)

@sreichel sreichel merged commit 6081bf1 into 1.9.4.x Sep 1, 2022
@sreichel sreichel deleted the phpstan-init-report branch September 1, 2022 03:31
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 6081bf1. ± Comparison against base commit e6e5ad7.

@fballiano fballiano mentioned this pull request Sep 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Admin Relates to Mage_Admin Component: Adminhtml Relates to Mage_Adminhtml Component: AdminNotification Relates to Mage_AdminNotification Component: Backup Relates to Mage_Backup Component: Catalog Relates to Mage_Catalog Component: CatalogSearch Relates to Mage_CatalogSearch Component: Core Relates to Mage_Core Component: Eav Relates to Mage_Eav Component: lib/Varien Relates to lib/Varien Component: lib/* Relates to lib/* Component: Rating Relates to Mage_Rating Component: Reports Relates to Mage_Reports Component: Sales Relates to Mage_Sales environment phpstan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants