-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phpstan: fixes for Varien_Data_Collection #2524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
fballiano
reviewed
Aug 30, 2022
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
b184d1c
to
35b5002
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
fballiano
approved these changes
Aug 31, 2022
Do you have plan to fix this: If the filtering is enabled in the grid, then the collection should have * @param Varien_Data_Collection|Varien_Data_Collection_Db $collection
*/
public function getCollection($collection)
// and: public function setCollection($collection) |
Yes. The "problem" is, that is has no impact on phpstan ... so i dont see it during my tests. Made a new PR. :) |
kiatng
approved these changes
Sep 1, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Admin
Relates to Mage_Admin
Component: Adminhtml
Relates to Mage_Adminhtml
Component: AdminNotification
Relates to Mage_AdminNotification
Component: Backup
Relates to Mage_Backup
Component: Catalog
Relates to Mage_Catalog
Component: CatalogSearch
Relates to Mage_CatalogSearch
Component: Core
Relates to Mage_Core
Component: Eav
Relates to Mage_Eav
Component: lib/Varien
Relates to lib/Varien
Component: lib/*
Relates to lib/*
Component: Rating
Relates to Mage_Rating
Component: Reports
Relates to Mage_Reports
Component: Sales
Relates to Mage_Sales
environment
phpstan
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
phpdocs/phpstan fix.
Contribution checklist (*)