Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpstan: fixed some unknown types #2538

Merged
merged 6 commits into from
Sep 2, 2022
Merged

phpstan: fixed some unknown types #2538

merged 6 commits into from
Sep 2, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 1, 2022

Description (*)

As title says.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Install Relates to Mage_Install Component: lib/Zend Component: PayPal Relates to Mage_Paypal Component: PaypalUk Relates to Mage_PaypalUk environment phpstan labels Sep 1, 2022
fballiano
fballiano previously approved these changes Sep 1, 2022
View reviewed changes
sreichel and others added 3 commits September 2, 2022 03:36
@sreichel @kiatng
Update app/code/core/Zend/Validate/EmailAddress.php
abbee57 
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
@sreichel @kiatng
Update app/code/core/Mage/Adminhtml/Block/System/Config/Tabs.php
a0949d3 
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
@sreichel @kiatng
Update app/code/core/Mage/Paypal/Model/Express/Checkout.php
c82d8f6 
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
@fballiano fballiano merged commit 22700c4 into OpenMage:1.9.4.x Sep 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 22700c4. ± Comparison against base commit 4db847a.

@sreichel sreichel deleted the phpstan-daily branch September 2, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiatng kiatng kiatng approved these changes

@fballiano fballiano fballiano approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Install Relates to Mage_Install Component: PayPal Relates to Mage_Paypal Component: PaypalUk Relates to Mage_PaypalUk environment phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sreichel @fballiano @kiatng