Use null coalescing operator #2543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Component: AdminNotification
|
did you do this manually? |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
PHPstorm shows possible usage of null coalescing operator ... i've run inspection for only that and changed that half-automated. (Y, i've checked every change) |
fballiano
previously approved these changes
Sep 6, 2022
kiatng
reviewed
Sep 9, 2022
Co-authored-by: Ng Kiat Siong <kiatsiong.ng@gmail.com>
This comment has been minimized.
This comment has been minimized.
fballiano
reviewed
Sep 9, 2022
| $this->setAggregator($arr['aggregator'] ?? ($arr['attribute'] ?? null)) | ||
| ->setValue($arr['value'] ?? ($arr['operator'] ?? null)); | ||
| $this->setAggregator($arr['aggregator'] ?? $arr['attribute'] ?? null) | ||
| ->setValue($arr['value'] ?? $arr['operator'] ?? null); |
There was a problem hiding this comment.
IMHO this is hard to understard, extremely short code is already less easy on the brain, but this (to me) it's a no. with the parenthesis was a bit better
There was a problem hiding this comment.
imho ... for me its easier to read w/o parenthesis. I can revert it later if you think it was better before.
There was a problem hiding this comment.
Ref https://www.php.net/manual/en/migration70.new-features.php, the operator can be chained. With parenthesis, it defeats the feature.
There was a problem hiding this comment.
Chaining seems to me a good argument against the additional parentheses.
kiatng
previously approved these changes
Sep 9, 2022
Sdfendor
previously approved these changes
Sep 9, 2022
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
kiatng
approved these changes
Sep 12, 2022
Sdfendor
approved these changes
Sep 12, 2022
addison74
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
There were a few comments in PRs to use null coalescing operator ... here we go.
Contribution checklist (*)