Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken grids caused by PR #2545 #2546

Merged
merged 1 commit into from
Sep 3, 2022
Merged

Fixed broken grids caused by PR #2545 #2546

merged 1 commit into from
Sep 3, 2022

Conversation

fballiano
Copy link
Contributor

All explained in #2545

@github-actions github-actions bot added the Component: Eav Relates to Mage_Eav label Sep 3, 2022
This was referenced Sep 3, 2022
Closed
Closed
@addison74
Copy link
Contributor

Tested and it fixes the issue.

@fballiano
Copy link
Contributor Author

Thanks.

Had changed it to for less changes ...

        $resource = Mage::getResourceModel($entityType->getEntityAttributeCollection());
        $attributesInfo = $resource

sorry man but i don't get what you said.

I would have re-used the same $attributesInfo variable but it didn't seem that clean (since there's the typehint) so I created attributesInfoData...

@fballiano fballiano merged commit 028f783 into OpenMage:1.9.4.x Sep 3, 2022
@fballiano fballiano deleted the fixed_regression_2545 branch September 3, 2022 08:34
@github-actions

This comment has been minimized.

Sign in to view
@sreichel
Copy link
Contributor

sreichel commented Sep 3, 2022

@fballiano 👍

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 028f783. ± Comparison against base commit 2d79049.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addison74 addison74 addison74 approved these changes

@sreichel sreichel sreichel approved these changes

@Flyingmana Flyingmana Flyingmana approved these changes

Assignees
No one assigned
Labels
Component: Eav Relates to Mage_Eav
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fballiano @addison74 @sreichel @Flyingmana