Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused controller Mage_Shipping_ShippingController #2564

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Removed unused controller Mage_Shipping_ShippingController #2564

merged 1 commit into from
Sep 7, 2022

Conversation

fballiano
Copy link
Contributor

Description (*)

Mage_Shipping_ShippingController was deprecated in M1.3 and seems not to be used anywhere, if you search for shipping/view there's nothing, and in the myaccount area there's only a link to the track shipment url, but not to view the shipping (what this code did).

If you check the controller's code, it wouldn't do anything anyway.

I've also checked its layout file app/design/frontend/base/default/layout/shipping.xml and there's nothing about this controller.

If I didn't miss anything it should be safe to remove this file.

@github-actions github-actions bot added the Component: Shipping Relates to Mage_Shipping label Sep 6, 2022
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL domain/shipping/shipping/view returns empty page.

@fballiano fballiano merged commit 77cfd17 into OpenMage:1.9.4.x Sep 7, 2022
@fballiano fballiano deleted the removed_unused_controller branch September 7, 2022 07:37
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 77cfd17. ± Comparison against base commit a731ed8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Shipping Relates to Mage_Shipping
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants