Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed some docs for phpdocumentor #2577

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Fixed some docs for phpdocumentor #2577

merged 2 commits into from
Sep 9, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 8, 2022

Description (*)

As title says. (group files correctly)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Authorizenet Relates to Mage_Authorizenet Component: Bundle Relates to Mage_Bundle Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: CatalogSearch Relates to Mage_CatalogSearch Component: Centinel Relates to Mage_Centinel Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Component: ImportExport Relates to Mage_ImportExport Component: Index Relates to Mage_Index Component: Page Relates to Mage_Page Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Shipping Relates to Mage_Shipping Component: Uploader Relates to Mage_Uploader Component: Usa Relates to Mage_Usa labels Sep 8, 2022
@kiatng
Copy link
Contributor

kiatng commented Sep 8, 2022

The email in @author Magento Core Team <core@magentocommerce.com> doesn't work anymore.

The recipient server did not accept our requests to connect. Learn more at [https://support.google.com/mail/answer/7720 magentocommerce.com 54.205.232.79: timed out] [magentocommerce.com 52.86.199.132: timed out] [magentocommerce.com 23.21.7.181: timed out] [magentocommerce.com 54.165.166.108: timed out]

@sreichel
Copy link
Contributor Author

sreichel commented Sep 8, 2022 •
edited
Loading

The email in @author Magento Core Team <core@magentocommerce.com> doesn't work anymore.

Keep it!? We dont need to change everything ...

@addison74
Copy link
Contributor

The email address could be removed if is not a valid one.

@fballiano
Copy link
Contributor

I'm not sure if legally we can remove the whole "@author Magento Core Team......" line, but if the email address doesn't exist anymore... mah...

@tmotyl
Copy link
Contributor

tmotyl commented Sep 8, 2022

cant phpdocumentor rely on folder structure?
I saw other PHP projects dropping @Package annotation completely.

@sreichel
Copy link
Contributor Author

sreichel commented Sep 8, 2022

Seems it use either namespace or package ...

https://docs.phpdoc.org/3.0/guide/references/phpdoc/tags/package.html

@fballiano fballiano merged commit 811cc5a into OpenMage:1.9.4.x Sep 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2022

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 811cc5a. ± Comparison against base commit a5541ff.

@sreichel sreichel deleted the phpdocumentor branch September 9, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elidrissidev elidrissidev elidrissidev approved these changes

@addison74 addison74 addison74 approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Authorizenet Relates to Mage_Authorizenet Component: Bundle Relates to Mage_Bundle Component: Captcha Relates to Mage_Captcha Component: Catalog Relates to Mage_Catalog Component: CatalogSearch Relates to Mage_CatalogSearch Component: Centinel Relates to Mage_Centinel Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Eav Relates to Mage_Eav Component: ImportExport Relates to Mage_ImportExport Component: Index Relates to Mage_Index Component: Page Relates to Mage_Page Component: Sales Relates to Mage_Sales Component: SalesRule Relates to Mage_SalesRule Component: Shipping Relates to Mage_Shipping Component: Uploader Relates to Mage_Uploader Component: Usa Relates to Mage_Usa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sreichel @kiatng @addison74 @fballiano @tmotyl @elidrissidev