Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added css class for sorted columns #2604

Merged
merged 2 commits into from
Sep 29, 2022
Merged

Added css class for sorted columns #2604

merged 2 commits into from
Sep 29, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Sep 17, 2022

Description (*)

Added CSS class for sorted grid column.

Slighty darker background ...

admingrid

Questions or comments

Maybe someone can check this and open PRs ...

  • select a grid row should add css-class selected to <tr> element (at least in OM admin theme a css-selector is already there)
    tbody tr {
      &.selected td {
        background: $color_alice_blue_approx;
      }

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml JavaScript Relates to js/* Template : admin Relates to admin template labels Sep 17, 2022
@fballiano fballiano merged commit 84fd844 into OpenMage:1.9.4.x Sep 29, 2022
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 84fd844. ± Comparison against base commit 7358174.

@sreichel sreichel deleted the admin-grid branch September 29, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Adminhtml Relates to Mage_Adminhtml JavaScript Relates to js/* Template : admin Relates to admin template
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants