Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phpstan: fixed return types (docs only) #2636

Merged
merged 32 commits into from
Oct 17, 2022
Merged

Phpstan: fixed return types (docs only) #2636

merged 32 commits into from
Oct 17, 2022

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Oct 1, 2022 •
edited
Loading

Description (*)

... no code changes ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Authorizenet Relates to Mage_Authorizenet Component: Backup Relates to Mage_Backup Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogSearch Relates to Mage_CatalogSearch Component: Checkout Relates to Mage_Checkout Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Eav Relates to Mage_Eav Component: Log Relates to Mage_Log Component: Media Relates to Mage_Media Component: Page Relates to Mage_Page Component: Paygate Relates to Mage_Paygate Component: PayPal Relates to Mage_Paypal Component: Sales Relates to Mage_Sales Component: Tax Relates to Mage_Tax environment phpstan labels Oct 1, 2022
@github-actions github-actions bot added Component: Shipping Relates to Mage_Shipping Component: Tag Relates to Mage_Tag Component: Tax Relates to Mage_Tax and removed Component: CatalogIndex Relates to Mage_CatalogIndex Component: CurrencySymbol Relates to Mage_CurrencySymbol Component: Contacts Relates to Mage_Contacts Component: AdminNotification Relates to Mage_AdminNotification Mage.php Relates to app/Mage.php Component: Admin Relates to Mage_Admin Component: Api PageRelates to Mage_Api Component: Cms Relates to Mage_Cms Component: Captcha Relates to Mage_Captcha Component: CatalogInventory Relates to Mage_CatalogInventory Component: CatalogRule Relates to Mage_CatalogRule Component: Centinel Relates to Mage_Centinel Component: Cron Relates to Mage_Cron labels Oct 11, 2022
@github-actions github-actions bot added the composer Relates to composer.json label Oct 11, 2022
@sreichel sreichel requested a review from kiatng October 14, 2022 00:17
@addison74
Copy link
Contributor

For some time now if you check the "Files changed" section in the browser of any PR you will see at the end errors reported in the OpenMage code by Phpstan. There are not many, but those who are using this extension could check their correctness and propose a PR.

@sreichel
Copy link
Contributor Author

These errors are currently suppressed with phpstan-baseline.neon, to pass checks ...

This has can be ignored and will be fixed step by step. Any help is appreciated :)

@sreichel sreichel merged commit 15f83af into OpenMage:1.9.4.x Oct 17, 2022
@sreichel sreichel deleted the phpstan/l3-1 branch October 17, 2022 21:14
@github-actions
Copy link
Contributor

Unit Test Results

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
7 runs  ±0  5 ✔️ ±0  2 💤 ±0  0 ❌ ±0 

Results for commit 15f83af. ± Comparison against base commit 27d0727.

@fballiano fballiano mentioned this pull request Oct 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elidrissidev elidrissidev elidrissidev left review comments

@addison74 addison74 addison74 approved these changes

@kiatng kiatng kiatng approved these changes

Assignees
No one assigned
Labels
Component: Adminhtml Relates to Mage_Adminhtml Component: Api2 Relates to Mage_Api2 Component: Authorizenet Relates to Mage_Authorizenet Component: Backup Relates to Mage_Backup Component: Bundle Relates to Mage_Bundle Component: Catalog Relates to Mage_Catalog Component: CatalogSearch Relates to Mage_CatalogSearch Component: Checkout Relates to Mage_Checkout Component: ConfigurableSwatches Relates to Mage_ConfigurableSwatches Component: Core Relates to Mage_Core Component: Customer Relates to Mage_Customer Component: Dataflow Relates to Mage_Dataflow Component: Directory Relates to Mage_Directory Component: Downloadable Relates to Mage_Downloadable Component: Eav Relates to Mage_Eav Component: Log Relates to Mage_Log Component: Media Relates to Mage_Media Component: Page Relates to Mage_Page Component: Paygate Relates to Mage_Paygate Component: PayPal Relates to Mage_Paypal Component: Sales Relates to Mage_Sales Component: Shipping Relates to Mage_Shipping Component: Tag Relates to Mage_Tag Component: Tax Relates to Mage_Tax composer Relates to composer.json environment phpstan
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sreichel @kiatng @addison74 @elidrissidev @justinbeaty @colinmollenhour @luigifab @przemyslaw-p